On Sun, 06.01.13 02:16, Tom Gundersen (t...@jklm.no) wrote: > >> >> +INSTALL_EXEC_HOOKS += \ > >> >> + myhostname-install-exec-hook > >> >> + > >> >> +UNINSTALL_EXEC_HOOKS += \ > >> >> + myhostname-uninstall-hook > >> >> +endif > >> > Are those hooks necessary? Other libs have hooks only if they are > >> > moved to rootlibdir during installation. > >> > >> Good point. The uninstall hook is indeed not necessary, I will remove > >> it. The install hook is necessary, or the .la file will be installed. > > > > Don't the other .la files get installed? Should libnss_myhostname be > > different? > > This was what the old nss-myhostname did. Lennart: any good reason to > exclude the .la or should nss-myhostname be treated the same as the > other libs?
Well, for the NSS modules .la files make particularly little sense as nobody ever links against them except with dlopen() called from inside libc. And naked dlopen() doesn't know .la files, hence we can just unconditionally remove them. Given that the rest of systemd is Linux-specific anyway we probably should remove all .la files from the installed tree, not just this one, but definitely these ones. (Also the lines for "_minimal.la" don't make much sense, this must be some left-overs from old code that doesn't exist anymore in the repo.) Lennart -- Lennart Poettering - Red Hat, Inc. _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
