On Mon, 11.02.13 16:34, Auke Kok (auke-jan.h....@intel.com) wrote:

> Contrary to it's own packaging guidelines, these symlinks are created
> in /etc/. While technically not a problem, this makes it harder
> for folks installing from git that want to override these settings
> (either masking or otherwise).
> 
> Moving the links to $(systemunitdir) resolves.

I am not sure we really should do this. Both of these units should be
allowed to be disabled, and always telling people to mask them sounds a
bit too much...

Dunno, I am a bit split about this. I see where you are coming from, but
just making them static sounds like too simple...

(Also, if we make them static we'd drop the [Install] section, as that
would be pointless then...)

So, I am really unsure... Dunno... Opinions?

> ---
>  Makefile.am | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 2cec04a..8945cfa 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -3622,8 +3622,8 @@ USER_UNIT_ALIASES += \
>       $(systemunitdir)/sound.target sound.target
>  
>  GENERAL_ALIASES += \
> -     $(systemunitdir)/remote-fs.target 
> $(pkgsysconfdir)/system/multi-user.target.wants/remote-fs.target \
> -     $(systemunitdir)/getty@.service 
> $(pkgsysconfdir)/system/getty.target.wants/getty@tty1.service \
> +     $(systemunitdir)/remote-fs.target 
> $(systemunitdir)/multi-user.target.wants/remote-fs.target \
> +     $(systemunitdir)/getty@.service 
> $(systemunitdir)/getty.target.wants/getty@tty1.service \
>       $(pkgsysconfdir)/user $(sysconfdir)/xdg/systemd/user \
>       ../system-services/org.freedesktop.systemd1.service 
> $(dbussessionservicedir)/org.freedesktop.systemd1.service
>  
> @@ -3650,8 +3650,8 @@ INSTALL_DIRS += \
>       \
>       $(userunitdir) \
>       $(pkgsysconfdir)/system \
> -     $(pkgsysconfdir)/system/multi-user.target.wants \
> -     $(pkgsysconfdir)/system/getty.target.wants \
> +     $(systemunitdir)/multi-user.target.wants \
> +     $(systemunitdir)/getty.target.wants \
>       $(pkgsysconfdir)/user \
>       $(dbussessionservicedir) \
>       $(sysconfdir)/xdg/systemd


Lennart

-- 
Lennart Poettering - Red Hat, Inc.
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to