On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (pho...@gmail.com) wrote:
Heya, looks good in principle. > + fn = "/etc/systemd/bootchart.conf"; > + f = fopen(fn, "re"); No need to open this if you don't have a reason to. config_parse() actually takes a NULL argument for the FILE* param, in which case it will open the file on its own. Passing FILE* sometimes makes sense for optimization when we do search path magic... > +[Bootchart] > +#Samples=500 > +#Freq=25 > +#Rel=0 > +#Filter=1 > +#Output=<folder name, defaults to /var/log> > +#Init=/path/to/init-binary > +#Pss=0 Hmm, so in systemd so far we tried to avoid abbreviations like this in exported identifiers. So I'd really prefer if we could use "Frequency" instead of "Freq" here. Abbreviations and acronyms raise the bar for newcomers. It's not to say we'd never export abbreviations/acronyms anywhere in systemd, but if we do, then they must be very very well established... Otherwise looks good. Lennart -- Lennart Poettering - Red Hat, Inc. _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
