On Wed, Feb 13, 2013 at 11:31 AM, Lennart Poettering <lenn...@poettering.net> wrote: > On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (pho...@gmail.com) > wrote: > >> +[Bootchart] >> +#Samples=500 >> +#Freq=25 >> +#Rel=0 >> +#Filter=1 >> +#Output=<folder name, defaults to /var/log>
This has changed to /run/log being the default with Harald's patch I merged yesterday. >> +#Init=/path/to/init-binary >> +#Pss=0 > > Hmm, so in systemd so far we tried to avoid abbreviations like this in > exported identifiers. So I'd really prefer if we could use "Frequency" > instead of "Freq" here. Abbreviations and acronyms raise the bar for > newcomers. agreed, as part of this conversion we should just rename these options to Frequency, Relative. > It's not to say we'd never export abbreviations/acronyms anywhere in > systemd, but if we do, then they must be very very well established... Pss, is still an acronym, but Let's keep it that way. Also, we should really add "Entropy=0" here too. > Otherwise looks good. Very much so! Do you want to respin? If not I'll happily apply it with the changes suggested above. Auke _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
