On Fri, 03.05.13 19:55, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:
> > On Fri, May 03, 2013 at 06:51:35PM +0200, Lennart Poettering wrote: > > On Wed, 24.04.13 10:30, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) > > wrote: > > > > > [ 0.019862] fedora kernel: CPU0: Thermal monitoring enabled (TM1) > > > [ 0.019900] fedora kernel: Last level iTLB entries: 4KB 512, 2MB 0, > > > 4MB 0 > > > Last level dTLB entries: 4KB 512, 2MB 32, > > > 4MB 32 > > > tlb_flushall_shift: 5 > > > [ 0.020118] fedora kernel: Freeing SMP alternatives: 24k freed > > > --- > > > A beginning of support for multiline messages. Is this the right approach? > > > > > > (Not all formats are updated). > > > > Hmm, maybe a simpler approach regarding the expansion of \n would be to > > extend strip_tab_ansi() to take an additional string param for what to > > expand \n to? I think that would be a much simpler patch, no? > We want to align fields, so it is necessary to split them on '\n'. > Otherwise it'd look like > > [ 0.019862] fedora kernel: CPU0: Thermal monitoring enabled (TM1) > [ 0.019900] fedora kernel: Last level iTLB entries: 4KB 512, 2MB 0, 4MB 0 > Last level dTLB entries: 4KB 512, 2MB 32, 4MB 32 > tlb_flushall_shift: 5 > [ 0.020118] fedora kernel: Freeing SMP alternatives: 24k freed > > which is definitely not pretty. Well, that's why I suggested to add a second param that specifies what \n shall be expanded to. In your example above you'd hence say that \n should be expanded to "\n " and you should be good? Lennart -- Lennart Poettering - Red Hat, Inc. _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel