Michael Biebl [2013-06-28 15:41 +0200]: > 2013/6/28 Lennart Poettering <lenn...@poettering.net>: > > On Fri, 28.06.13 10:06, Holger Hans Peter Freyther (hol...@freyther.de) > > wrote: > > > >> Well, that is one part. "make test" really just checks if the test/ > >> directory exists, it doesn't really contribute to the quality control. > >> > >> The other thing with "make check" is that it is failing if the build > >> system doesn't run systemd[1]
It's not actually that bad, the problem is that the test suite assumes that /etc/machine-id exists which is not the case in minimal build chroots. This is what I addressed with the patch in https://bugs.freedesktop.org/show_bug.cgi?id=62344 (which we apply in Ubuntu), but it was rejected upstream. I disagree to the rationale, as unit tests should not make this kind of assumption about their environment, but it isn't important enough to argue about this endlessly. :-) > Being able to run the systemd test suite without having systemd as pid > 1 would certainly be nice, as we could then activate the test suite as > part of our (Debian) build process and it would be run on all the > different architectures. We do that in Ubuntu, should work as well in Debian with above patch. Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
