-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 19.08.2013 11:58, schrieb Harald Hoyer: > On 08/19/2013 11:21 AM, Thomas Bächler wrote: >> Am 19.08.2013 10:34, schrieb Harald Hoyer: >>> Hmm, the naming "luks.options" is IMHO poorly chosen. "options" >>> as an option name... hmm. Also crypttab can contain more >>> encryption modes, than LUKS. >>> >>> If you want to reflect crypttab, why not specify something >>> like: >>> >>> [rd.]crypttab=<name>;<device>;<password>;<options> > >> So, systemd-cryptsetup-generator currently reads luks, >> luks.crypttab, luks.uuid and luks.key (+ the rd. variants). Now >> you are proposing to add a 'crypttab' option as well. This seems >> awfully inconsistent to me. > > Well, I think before adding more and more rd.luks parameters, we > might want to step back and add one option, which supports all.
When you phrase it that way, I must fully agree. > An object oriented syntax might be: > > rd.luks.<uuid>.name=<name> rd.luks.<uuid>.options=<options> > rd.luks.<uuid>.password=<password> > > This of course would have made parsing with shell functions > unpractical. > > Now that we already have rd.luks.uuid=<uuid> adding parameters to > <uuid> results in > > rd.luks.options=<uuid>=<options> rd.luks.name=<uuid>=<name> > rd.luks.password=<uuid>=<password> > > Both solutions blow up the length of the kernel command line and > make it really unreadable. Agreed. Your initial [rd.]crypttab=<name>;<device>;<password>;<options> proposal sounds reasonable. Is ';' a good separator for this (I think it is, just making sure I don't overlook something)? Should the [rd].luks* options be deprecated at the same time? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJSEgDEAAoJEChPw0yOSxolVQgP/3hAox/FdrCKi7BMs5rsSe+r NHXnu9nOngBLRHw/DnICQ5HoMAX1HDHLUOdqeWOt4XVI0jn4RDFivzIZnSmpf6QS zi8/oltC38gBd8LyKNfklt3tF6xw5/pfrIBe6DGa6clYywUd9daIsdOXN3sh7yHK InEn3oyfPA4Eno0p5d6hKn4g03KJlsgm313V2Fxr97y6enu2yJjeemlmdOoyMeNf FcUqphobaJWiGYqePEyLJtKoaNq91h6CnLNVQJ8dIIleZeGmCwwpv8xT4A8WyjXQ cRIrDvo7bHMBIHPdFV+UPZ+Crn7OTnJBDTKFJzttnEY8AYI4vpc7kcuTD8yVHxln K/c/NGEuYjO50e26Sso12kFicTXexdXxdELijMZ2MzHpTd6hFeHwa9R5/ts3ZasS AQJLqtVOpJMT2EMnk48JLgOpkgGJiXTs8wC08DMuYP1KjOWa43/EFy1KCHoA6N8G L47meHpIw0EzRgMXtXGBcmFKDbrGZeuX/gxnhAAw17ZO1X0K5sY1Y2FWanc21kqq Zn3PK1OHGlLwiqhblo6hrv0LNRNh1oYJtbQel1DbS60v8Pq3qidsb0IVB8vUuZ8M Zgnjk7N1GgY2DiYkBVjzpvD7og74hK8pf4vvRC/WkmbOsG2VqW1grejzAoF8T1I0 P/f/Zne4C5KGYvBdHhV2 =gtpu -----END PGP SIGNATURE----- _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
