Hi On Sun, Dec 1, 2013 at 4:13 PM, Colin Walters <walt...@verbum.org> wrote: > On Sun, 2013-12-01 at 01:26 +0100, Zbigniew Jędrzejewski-Szmek wrote: > >> Actually I don't think we need to totally forbid declarations after >> statements. > > I don't have an opinion myself on making -Wdeclaration-after-statement > an error or not, but presently with GCC 4.7 as in gnome-continuous, > we get a spam of warnings: > > http://build.gnome.org/continuous/buildmaster/builds/2013/11/30/25/build/warnings-systemd.txt > > And the goal of the patch is to quiet those with older gcc versions.
Same for gcc-4.8.2 here on Arch. The Fedora (also 4.8.2) apparently doesn't have these problems. So seems to be related to gcc build-flags.. maybe some-one can report them upstream? As a workaround you can always pass -Wno-declaration-after-statement to local CFLAGS. Cheers David _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel