On Sun, 01.12.13 10:13, Colin Walters (walt...@verbum.org) wrote:

> 
> On Sun, 2013-12-01 at 01:26 +0100, Zbigniew Jędrzejewski-Szmek wrote:
> 
> > Actually I don't think we need to totally forbid declarations after 
> > statements.
> 
> I don't have an opinion myself on making -Wdeclaration-after-statement
> an error or not, but presently with GCC 4.7 as in gnome-continuous,
> we get a spam of warnings:
> 
> http://build.gnome.org/continuous/buildmaster/builds/2013/11/30/25/build/warnings-systemd.txt
> 
> And the goal of the patch is to quiet those with older gcc versions.
> 
> (I briefly investigated the memset one but couldn't find it...)

Note that we now use "-flto" during optimized builds which will make
systemd quite a bit smaller, but will totally destroy the usefulness of
the compiler warnings on current gcc versions. You might want to turn
off lto explicitly for gnome-continuous for now...

Lennart

-- 
Lennart Poettering, Red Hat
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to