On Tue, 17.12.13 15:59, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote:
> > > diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
> > > index 327eb85..aab92c4 100644
> > > --- a/src/systemctl/systemctl.c
> > > +++ b/src/systemctl/systemctl.c
> > > @@ -3797,7 +3797,10 @@ static int cat(sd_bus *bus, char **args) {
> > > }
> > >
> > > if (!isempty(fragment_path)) {
> > > - fprintf(stdout, "# %s\n", fragment_path);
> > > + fprintf(stdout, "%s# %s%s\n",
> > > + ansi_highlight_blue(),
> > > + fragment_path,
> > > + ansi_highlight_off());
> >
> > Hmm, do we really want yet another color for this? In particular since
> > blue is somewhat hard to see on black?
> >
> > I think sticking to traffic light colors + bold should be
> > enough. Wouldn't ANI_HIGHLIGHT_ON work here nicely too?
> I didn't use HIGHLIGHT because I didn't want to attract attention to
> the line, and picked blue because it is low key. Let's leave it as is
> for a few days to get used to blue, and if it still doens't work, then
> I'll change it.
Hmm, but that sounds like we should "grey" it out, no? The same way we
have a way to highlight things maybe we want the opposite as a way to
deemphasize things and color it grey in some way? (Not sure though
whether there's a nice grey in the ANSI color range?)
Lennart
--
Lennart Poettering, Red Hat
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
