On Wed, 08.10.14 08:30, Daniel Mack (zon...@kemper.freedesktop.org) wrote:
>
> - /* The higher 32bit of the flags field are considered
> - * 'incompatible flags'. Refuse them all for now. */
> - if (make->flags > 0xFFFFFFFFULL) {
> + /* The features field are considered 'incompatible flags'.
> + * Refuse them all for now. */
> + if (make->features) {
> safe_close(fd);
> return -ENOTSUP;
This appears the wrong way around, we discussed in Berlin yesterday
that "features" should be the compatible bitmask, and "flags" should
be the incompatible one.
Lennart
--
Lennart Poettering, Red Hat
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
