On Thu, Jan 29, 2015 at 06:44:23PM +0100, Didier Roche wrote: > Le 28/01/2015 15:53, Zbigniew Jędrzejewski-Szmek a écrit : > >On Wed, Jan 28, 2015 at 02:22:54PM +0100, Didier Roche wrote: > >> From 104cf82ba28941e907f277a713f834ceb3d909f0 Mon Sep 17 00:00:00 2001 > >>From: Didier Roche <didro...@ubuntu.com> > >>Date: Mon, 26 Jan 2015 16:40:52 +0100 > >>Subject: [PATCH 06/12] Support cancellation of fsck in progress > >> > >>Grab in fsckd plymouth watch key for C or c, and propagate this cancel > >>request > >>to systemd-fsck which will terminate fsck. > >Could we bind to ^c or if this is not possible, "three c's in three > >seconds" instead? I'm worried that before you could press anything to little > >effect in plymouth, and now a single key will have significant consequences. > > > I tried to have a look at libplymouth, and if I'm correct, it's not > possible to listen and get events for compose keys, so no way to get > something like Control+C. As Dimitri told, it's been quite some > years we are doing that in ubuntu, and that's the reason why we show > a message to ensure the user is aware about that key (and that's why > this patch is doing). Is it good for you this way? I think so. We can always improve the interface later on if it's confusing for users.
(If plymouth forwards the key to us, we could detect "triple c within two seconds" ourselves. But if you think that a single key is fine, than that's fine for me.) Zbyszek _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
