On Wed, 18.02.15 07:47, Martin Pitt (mar...@kemper.freedesktop.org) wrote: Martin,
I looked in more detail at the fsckd code that was commited a few weeks ago, and I cannot say I liked what I saw. The code still has all kinds of issues, including memory corruptions, fd handling errors, and tons and tons of incorrect error handling (I think more times the code passes an incorrect error to log_xyz_errno() than a correct one!). And there are conceptional issues with the code too (for example, it's not OK to keep /dev/console open, this breaks the SAK key logic...) Please, be more careful with complex code like this, this needs more rounds of review before something like this can be merged... Next time, please be more careful! > .gitignore | 1 > Makefile-man.am | 12 > Makefile.am | 16 + > configure.ac | 1 > man/systemd-f...@.service.xml | 26 - > man/systemd-fsckd.service.xml | 162 ++++++++++ > po/POTFILES.in | 1 > po/de.po | 11 > po/el.po | 11 > po/fr.po | 11 > po/hu.po | 11 > po/it.po | 11 > po/pl.po | 11 > po/pt_BR.po | 11 > po/ru.po | 11 > po/sv.po | 11 > po/uk.po | 12 > src/fsck/fsck.c | 125 +++----- > src/fsckd/Makefile | 1 > src/fsckd/fsckd.c | 554 > +++++++++++++++++++++++++++++++++++++ > src/fsckd/fsckd.h | 38 ++ > src/shared/util.c | 8 > src/shared/util.h | 2 > test/mocks/fsck | 27 + > units/.gitignore | 1 > units/systemd-fsck-root.service.in | 3 > units/systemd-f...@.service.in | 4 > units/systemd-fsckd.service.in | 17 + > units/systemd-fsckd.socket | 14 > 29 files changed, 1038 insertions(+), 86 deletions(-) Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
