On Tue, 10.03.15 08:39, Didier Roche (didro...@ubuntu.com) wrote: > Le 10/03/2015 08:33, Martin Pitt a écrit : > >Lennart Poettering [2015-03-09 19:11 +0100]: > > > >>Oh, and I am only realizing now that the whole thing doesn't do *at > >>all* what we discussed. The idea was to invoke the actual fsck tools > >>with their stdout connected directly to fsckd. Instead the old > >>systemd-fsck tool still is the one that parses the fsck output and > >>which now simply forwards that info. > >That didn't actually come up during review, but that sounds like a > >nice idea! I see two structures: > > > > - s-fsck runs fsck and forwards its stdout/err fds to fsckd, and then > > fsckd does all the parsing. This would also automatically eliminate > > the intermediate socket handling from above. > > We will still need the cancel message back socket (so below).
Use SO_PEERCRED from the systemd-fsckd side to identify the PID of the connected fsck instance. Then, send the SIGTERM directly to it. There's no need to proxy this off systemd-fsck. Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
