On Tue, Jun 2, 2015 at 11:53 AM, Kay Sievers <k...@vrfy.org> wrote: > On Tue, Jun 2, 2015 at 4:34 PM, Martin Pitt <martin.p...@ubuntu.com> wrote: >> David Herrmann [2015-06-02 13:06 +0200]: >>> Our preferred way to send future patches is "the github way". This >>> means sending pull-requests to the github repo. Furthermore, all >>> feature patches should go through pull-requests and should get >>> reviewed pre-commit. This applies to everyone. Exceptions are >>> non-controversial patches like typos and obvious bug-fixes. >> >> Makes sense. On the operational level, should we use the >> "automatically merge" feature of git hub once approving? On the plus >> side it's very convenient, but you'll get one "Merge" commit for every >> PR (which is often just one commit), so we'd almost double the entries >> in "git log". Or can github be told to not do that? >> >> Merging manually is quite a bit of work, as you have to add a new >> remote every time, fetch that, and pull from it. But it does keep a >> cleaner git log history. > > Use github. > > With the decision to move to github, we need to accept the github > model and with that accept possible cosmetic issues.
Have you guys found a way to preserve the comments on pull requests? I don't see it as a cosmetic issue but this was rather the reason I moved projects away from github in the past. As a maintainer of other projects I need to point to a discussion on a single patch and be able to see the previous iterations of a patch. And also check what was the conclusion on a patch set that was accepted in the repository. It's also nice for developers to check if there was any attempt already in implementing some feature and it was denied by any reason. Last time I checked this is impossible with github because you lose the comments on each patch when a second version arrives. Of course this is a non-issue for several projects in github which don't have proper commit review. It's not the case of systemd and it seems it's even the reason why you are moving to github. So I'm just curious if anything changed in this regard or you solved it in another way. thanks -- Lucas De Marchi _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
