B1;4002;0cOn Wed, 10.06.15 08:25, Filipe Brandenburger (filbran...@google.com) wrote:
> On Wed, Jun 10, 2015 at 6:31 AM, Alban Crequy <al...@endocode.com> wrote: > >>> Instead, just reuse the same PR and use `git push -f` to ship new > >>> versions of the commits to the same branch... Yes it's awful but > >>> unfortunately that's how GitHub works... > >> > >> Yeah, it is awful, and loses all the comments, as well is incompatible > >> with having multiple people making patch suggestions for the same > >> issue. > > > > FWIW it only loses the comments if people comment on individual > > commits instead of commenting on the "Files changed" tab of a PR. I > > usually comment in this way on purpose instead of commenting on > > commits, so that the history of comments are kept in the PR, even > > after rebase (it might be folded if the chunk of the patch is not > > there anymore, but the comment is still in the PR). If you really want > > to comment on an individual commit (but I don't recommend it), you can > > include the reference of the PR in your comment (#42), then github > > will keep your comment attached to the PR. > > Ah that makes sense! > > Indeed as I explained I like to look at the individual commits, so > that would explain why my comments would get lost as a new version is > pushed... > > > I think it is fine as it is as long as people comment in the "Files > > changed" tab. > > Lennart, do you think setting that rule is better than the "one PR per > version of patchset"? No. We should review commits, not diffs. We also should review commit msgs. (see other mail) Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
