Morgan Delagrange wrote:
> I haven't seen any feedback yet on the new version of
> the JDBC tag library. If there isn't any interest in
> reviewing the tags, can we vote to release?
Morgan,
I tested the jdbc tag-library with my webapp on win2k with MySQL
and it worked fine. Thanks for a great contribution!
In the process of learning/using the library, a few "minor" things
along with questions/comments came up. I've listed them at the
end of this email.
With respect to the "release" vote, I must admit I'm a bit
confused about what this means.
What will change in the status of the jdbc
tag library, since it is already committed in the
jakarta-taglibs workspace?
Thanks,
-- Pierre
-----
TLD
teiclass not properly positioned for the connection 'tag'
The tag element in the TLD is defined as follows:
<!ELEMENT tag
(name, tagclass, teiclass?,
bodycontent?, info?, attribute*) >
'teiclass' should come before bodycontent, which is not
the case for the 'connection' tag in the TLD (also in the examples).
[This fails under tomcat-4.0
org.xml.sax.SAXParseException: Element "tag" does not allow "teiclass" here.
-----
<sql:execute>
<sql:execute> is only used for insert, update, or delete statements.
Since an 'execute' is not required for 'select', why is it required
for insert, update, and delete?
Also, ignoreErrors only available for <sql:execute>.
What about queries?
-----
scripting variables
In the docs, when a scripting variable is returned, its properties
are described. However, not all properties are listed
(e.g. autoCommit for connection).
-----
wrong syntax in example:
<sql:execute>
<sql:setColumn position="1">3</sql:setInt>
<sql:setColumn position="2"><%=request.getParameter("book_title")%></sql:setString>
</sql:execute>
</sql:setInt> and </sql:setString> should be </sql:setColumn>
-----
