--- Pierre Delisle <[EMAIL PROTECTED]> wrote:
> Morgan Delagrange wrote:
> > I haven't seen any feedback yet on the new version
> of
> > the JDBC tag library. If there isn't any interest
> in
> > reviewing the tags, can we vote to release?
>
> Morgan,
>
> I tested the jdbc tag-library with my webapp on
> win2k with MySQL
> and it worked fine. Thanks for a great contribution!
Thanks. :)
> In the process of learning/using the library, a few
> "minor" things
> along with questions/comments came up. I've listed
> them at the
> end of this email.
>
> With respect to the "release" vote, I must admit I'm
> a bit
> confused about what this means.
> What will change in the status of the jdbc
> tag library, since it is already committed in the
> jakarta-taglibs workspace?
Well, we haven't really committed to stabilizing the
interface yet. Witness that I removed some 40 odd
classes last week. After we put a link on the website
and make an announcement to the users' group, we'll
try not to do that.
More comments below.
> Thanks,
>
> -- Pierre
>
> -----
> TLD
> teiclass not properly positioned for the connection
> 'tag'
>
> The tag element in the TLD is defined as follows:
>
> <!ELEMENT tag
> (name, tagclass, teiclass?,
> bodycontent?, info?, attribute*) >
>
> 'teiclass' should come before bodycontent, which is
> not
> the case for the 'connection' tag in the TLD (also
> in the examples).
>
> [This fails under tomcat-4.0
> org.xml.sax.SAXParseException: Element "tag" does
> not allow "teiclass" here.
Fixed. Good catch!
> -----
> <sql:execute>
>
> <sql:execute> is only used for insert, update, or
> delete statements.
> Since an 'execute' is not required for 'select', why
> is it required
> for insert, update, and delete?
I tried to create two categories: stuff that loops
(resultSet) and stuff that doesn't (execute). Maybe I
should clarify this in the documentation somehow.
> Also, ignoreErrors only available for <sql:execute>.
> What about queries?
I couldn't think of any resultset errors you would
want to ignore, while I could think of possibliy
harmless execution errors (e.g. attempted primary key
violations).
> -----
> scripting variables
>
> In the docs, when a scripting variable is returned,
> its properties
> are described. However, not all properties are
> listed
> (e.g. autoCommit for connection).
Yeah, I ignored properties that didn't seem
user-friendly. They're still accessible, they're just
not documented.
> -----
> wrong syntax in example:
>
> <sql:execute>
> <sql:setColumn position="1">3</sql:setInt>
> <sql:setColumn
>
position="2"><%=request.getParameter("book_title")%></sql:setString>
> </sql:execute>
>
> </sql:setInt> and </sql:setString> should be
> </sql:setColumn>
Ah, I must have missed that one. Thanks! (and
fixed.)
> -----
Thanks for your excellent comments!
- Morgan
=====
Morgan Delagrange
Britannica.com
__________________________________________________
Get personalized email addresses from Yahoo! Mail - only $35
a year! http://personal.mail.yahoo.com/
