Hello Henri, Having a protected configureFormatter (and similar things for other methods elsewhere) is my preferred approach.
The issue with the second approach is that doEndTag() calls createFormatter(), then configureFormatter, then formats the text. There's no facility to step in between and make changes. If the other methods stayed private, we'd have to re-implement them if we re-implemented doEndTag() anyway. So there is nothing gained by having a reconfigureFormatter(DateFormat). On Fri, Jul 10, 2009 at 3:25 AM, Henri Yandell <flame...@gmail.com> wrote: > I'm wondering if protected configureFormatter(NumberFormat) is best, > or if the better option is to have a protected void > reconfigureFormatter(NumberFormat) method that is invokved at the end > of that method. > > So by default the configureFormatter is always run, and then the user > can hook in to do whatever they want to the NumberFormat. A similar > reconfigureFormatter(DateFormat) could be added to the > FormatDateSupport class. > > What do you think? > > -- Stuart Thiel