On Jun 25, 2007, at 14:39 , Felix - wrote:

1. It generates directory adds when necessary.  p4 doesn't track
directories, so when you add a file to a new directory, p4 doesn't
have an add event for the directory.  Without this patch, svn fails
when it tries to add a file in a directory that hasn't been added.

2. It generates directory removes when the last file gets removed.
This is mainly cosmetic.

Neat, thanks. I was primarily focused on p4 -> hg (which also doesn't do directories), so it makes sense that I would've overlooked this.

3. It detects p4 renames (branch+delete), and turns them into rename events.

4. It runs a little faster.  Without this patch, tailor runs 'p4
describe' twice for every changeset.  This reduces it to once.

        Good, good.

I did a replication of my work tree (the only p4 tree I have to care about) to hg with this and it seemed to produce the same results as the original, but with more warnings.

Tailor is complaining about files already having been added when the directory and individual files are both added. I think this has more to do with the hg target side and so far doesn't seem to be harmful, so I'll not worry about it with respect to this patch.

Do you want to deliver this as a darcs patch with your name on it, or would you rather I submit it under my name (or someone else's if someone else wants to apply the same patch)?

        ``darcs send'' is the easiest way to get your patches in.

--
Dustin Sallings


_______________________________________________
Tailor mailing list
[email protected]
http://lists.zooko.com/mailman/listinfo/tailor

Reply via email to