On Jun 25, 2007, at 16:53 , Felix - wrote:

On 6/25/07, Dustin Sallings <[EMAIL PROTECTED]> wrote:
Tailor is complaining about files already having been added when the
directory and individual files are both added.  I think this has more
to do with the hg target side and so far doesn't seem to be harmful,
so I'll not worry about it with respect to this patch.

hm.  I was wondering whether it was better to fix the dir adds at the
p4 source or at the svn target.  it's not clear to me what tailor
thinks is a canonical changeset.  my instinct is that fixing it in svn
target would be better, but I did the fix at p4 source because cvs
source also does something similar, and that seemed likely to be
canonical.

so which makes more sense?

Perhaps directory operations should be isolated. The directory information can be computed with common code for sources that don't handle directories as well as processed consistently for targets that don't understand them.

Do you want to deliver this as a darcs patch with your name on it,
or would you rather I submit it under my name (or someone else's if
someone else wants to apply the same patch)?

sure, go ahead and submit it, I don't care.  I'm still fiddling with
darcs (destroyed and recreated my repo a couple times, it's not in a
sane state right now.)

It's apparently already gone through under your name. :) I pulled it a few minutes ago.

--
Dustin Sallings


_______________________________________________
Tailor mailing list
[email protected]
http://lists.zooko.com/mailman/listinfo/tailor

Reply via email to