Hello, sajolida: > u: >> sajolida: >>> u: >>>> sajolida: >>>>> u:
> So I procrastinated for about one hour on removing the subtitle from our > canonical logo. This allowed me then to reuse it as such in the banner > and have the exact same version work on mobile as well. We're down from > 3 variations to 1! > > I pushed that in feature/smallCSSfixes. > > Tell me what you think. I think it's nice BUT there needs to be more space on top and bottom. Stuff needs to breathe.. So please don't add a padding or anything, because this will break other stuff I did in the donation banner branch, but instead make the image slightly smaller. Now it's 100px in height and the the whole banner is 114px high. I think we need at least 10-15px on top and below, so the logo should not be higher than 90px. Also, what I find weird is that the USB stick is not horizontally aligned with the text. You see, the stick is higher than the T and lower too. I can live with this. But I can't live with the missing breathing space. > And regarding your branch, I'm fine merging it once we agree on > something regarding the logo (or even before if you think it will be a > complicated discussion). > > Still, I spotted one little detail (see attachment): in the Farsi > version the search box is much taller. I narrowed the problem down to > having a bigger line-height in the input field in there (34px instead of > 22px reported by Tor Browser). Then I couldn't see where this was coming > from... But I think we can ignore that, unless you find a quick way of > solving it. I cannot confirm that I see this. And I think you did not push your modification. Please note that in the donation banner branch I did some other modifications, like giving a unit to the line-height on body. Which was actually never taken into account... because of the missing unit :) ANd I think this fixes quite a lot of stuff. Please let me know if you need anything else from me before merging this branch. Cheers u. _______________________________________________ Tails-dev mailing list [email protected] https://mailman.boum.org/listinfo/tails-dev To unsubscribe from this list, send an empty email to [email protected].
