On 2/18/2010 11:32 AM, Alan Williams wrote:
> Wei Tan wrote:
>    
>> Hmm, another issue I found in CredentialManager.java is:
>>
>> /**
>>        * Returns a CredentialManager singleton.
>>        */
>>       public static CredentialManager getInstance() throws CMException {
>>           synchronized (CredentialManager.class) {
>>               if (INSTANCE == null) {
>>
>>                   INSTANCE = new CredentialManager();
>>               }
>>           }
>>           return INSTANCE;
>>       }
>>
>> I change    INSTANCE = new CredentialManager(masterPassword);
>> to INSTANCE = new CredentialManager();
>>      
> That has been changed both in the main trunk and in the
> CredentialManager that was in the patch (or should be).  Can you send me
> the URL to the svn of where it isn't changed?
>    
Source code
http://taverna.googlecode.com/svn/taverna/engine/net.sf.taverna.t2.security/tags/security-1.0.1
http://taverna.googlecode.com/svn/taverna/ui/net.sf.taverna.t2.ui-components/tags/ui-components-1.0.1/credential-manager-ui

Jar: from mygrid Maven repository.

>    
>> Because when instance is null, a dialogue should be popped up for user
>> input of the master password.
>> I might be wrong but when I fix this and the SPI definition in
>> credential-manager-ui, my cagrid-activity
>> seems to work fine as it did before.
>>
>> Too difficult for me to spot these :-)
>>      
> I think the hard learned lesson is that it may be easier to do a new
> release than a patch :(
>
>    
>> Wei
>>      
> Alan
>
> ------------------------------------------------------------------------------
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> taverna-hackers mailing list
> [email protected]
> Web site: http://www.taverna.org.uk
> Mailing lists: http://www.taverna.org.uk/taverna-mailing-lists/
> Developers Guide: http://www.mygrid.org.uk/tools/developer-information
>    

-- 
Wei Tan, Ph.D.
Computation Institute
the University of Chicago|Argonne National Laboratory
http://www.mcs.anl.gov/~wtan


------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
taverna-hackers mailing list
[email protected]
Web site: http://www.taverna.org.uk
Mailing lists: http://www.taverna.org.uk/taverna-mailing-lists/
Developers Guide: http://www.mygrid.org.uk/tools/developer-information

Reply via email to