Hi!
I forgot to mention that the initialization of g_log_targets in printk.c is pointless. g_log_targets
is always overwritten by get_tboot_log_targets() because get_option_val() will return "serial" if
logging isn't specified via command line.
I suggest to remove "serial" from g_tboot_cmdline_options[] in cmdline.c
(see attached diff)
Michael
diff --git a/tboot/common/cmdline.c b/tboot/common/cmdline.c
--- a/tboot/common/cmdline.c
+++ b/tboot/common/cmdline.c
@@ -67,7 +67,7 @@
/* global option array for command line */
static const cmdline_option_t g_tboot_cmdline_options[] = {
{ "loglvl", "all" }, /* all|none */
- { "logging", "serial" }, /* vga,serial,memory|none */
+ { "logging", "" }, /* vga,serial,memory|none */
{ "serial", "com1" }, /* com[1|2|3|4] or its IO port (e.g. 0x3f8) */
/* comX=<baud>[/<clock_hz>][,<DPS>[,<io-base>[,<irq>[,<serial-bdf>[,<bridge-bdf>]]]]] */
{ "com1", "115200,8n1" },
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
tboot-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tboot-devel
