I like to keep the defaults together, i.e. in cmdline.c. There are inconsistencies with the logging defaults there and the ones assigned to g_log_targets, so I will correct that (eventually).
Joe > -----Original Message----- > From: Michael Gissing [mailto:m.giss...@tugraz.at] > Sent: Thursday, July 22, 2010 8:01 AM > To: tboot-devel@lists.sourceforge.net > Subject: Re: [tboot-devel] Incorrect command line handling with GRUB 1.97 and > above > > Hi! > > I forgot to mention that the initialization of g_log_targets in printk.c is > pointless. > g_log_targets is always overwritten by get_tboot_log_targets() because > get_option_val() will > return "serial" if logging isn't specified via command line. > > I suggest to remove "serial" from g_tboot_cmdline_options[] in cmdline.c (see > attached diff) > > Michael ------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://p.sf.net/sfu/dev2dev-palm _______________________________________________ tboot-devel mailing list tboot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tboot-devel
