On Sun, 2011-04-03 at 20:27 +0200, Michael Richardson wrote: > >>>>> "Rick" == Rick Jones <[email protected]> writes: > Rick> tcpdump 4.1.1, and 4.3.0-PRE-GIT_2011_04_01 prints just one > Rick> expanded counter sample per captured PDU because it mistakenly > Rick> skips forward sflow_sample_len when it has already adjusted > Rick> tprt and tlen while it was printing the sample contents. This > > Can you send pcap file with reference output as well for 'make check'?
The former is easy enough - attached is a compressed pcap file with 30 captured PDUs which can be used for testing. They are all just counter samples, there are no flow samples. Also attached is a compressed "cooked" file with the correct output based on Guy's patch. I've given it a quick once-over to verify that it looks sane. As for the latter, I don't have some of the pre-reqs installed: raj@tardy:~/tcpdump$ make check uudecode --help || (echo "No uudecode program found, not running tests"; echo "apt-get/rpm install sharutils?"; exit 1) /bin/sh: uudecode: not found No uudecode program found, not running tests apt-get/rpm install sharutils? make: *** [check] Error 1 so unless it is particularly important to have I'd rather not bother. happy benchmarking, rick
sflow_multiple_counter_30_pdus.pcap.gz
Description: GNU Zip compressed data
sflow_multiple_counter_30_pdus.cooked.gz
Description: GNU Zip compressed data
- This is the tcpdump-workers list. Visit https://cod.sandelman.ca/ to unsubscribe.
