On Apr 4, 2011, at 12:15 PM, Rick Jones wrote:
> As for the latter, I don't have some of the pre-reqs installed:
>
> raj@tardy:~/tcpdump$ make check
> uudecode --help || (echo "No uudecode program found, not running tests";
> echo "apt-get/rpm install sharutils?"; exit 1)
> /bin/sh: uudecode: not found
> No uudecode program found, not running tests
> apt-get/rpm install sharutils?
> make: *** [check] Error 1
>
> so unless it is particularly important to have I'd rather not bother.
Well, either
1) you don't have uudecode installed
*OR*
2) you have a version of uudecode installed that doesn't support
"--help" - some versions do, but:
http://bizsupport1.austin.hp.com/bc/docs/support/SupportManual/c01922474/c01922474.pdf
some don't.
I've checked in changes to Makefile.in on the trunk so that we don't depend on
"uudecode --help" working...
...but the bigger question is whether we need to bother with uuencoding the
regression test capture files at all. If I do "git log mpls-ldp-hello.pcap",
it says
$ git log mpls-ldp-hello.pcap
commit f6e9b6b8f041138196d986561515594aeccaceff
Author: mcr <mcr>
Date: Wed Apr 6 21:26:57 2005 +0000
make sure that pcap files are uu-encoded to avoid any
confusion.
commit 6b2cc5bedd94267c73f800e3e5c7608c35f1faba
Author: hannes <hannes>
Date: Thu Jan 8 07:10:59 2004 +0000
add a testcase for a LDP Hello encapsulated in MPLS
At the time, we were using CVS, and it might have had some problems with handle
binary blobs; Michael, was that the reason you uuencoded the capture files?
We now use Git, which I think may handle binary blobs better, and we now have
some pcap files checked in without uuencoded versions being checked in, e.g.
the ForCES test files.
Should we just get rid of the .puu files (after making sure they uudecode into
the corresponding .pcap files), and get rid of the uudecode requirement?-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.
