On Nov 14, 2003, at 5:17 PM, Guy Harris wrote:
1) any chance of removing unused rcsid variables? grep suggests they are always defined but never used. Alternately, move it below the include "interface.h" and edit it to say:
static const char rcsid[] _U_ =
The same issue exists with libpcap. The right place to put the definition of _U_ is probably "pcap-int.h". Putting in the definition of "__attribute__()" as a do-nothing macro, as per tcpdump, would probably be the right thing to do; that'd let us get rid of an #ifdef in "gencode.h".
I've attached a version of the script that should do the right thing for libpcap. It doesn't handle all files -- Win32/Src/getaddrinfo.c is a bad case for the script, and bpf_filter.c uses #if instead of #ifdef so that it can be used in kernel code.
It assumes "pcap-int.h" has the _U_ definition.
thanks, -neil
movercsid-libpcap.rb
Description: Binary data
