On Sun, Dec 17, 2000 at 08:45:49PM -0800, Guy Harris wrote:
> On Fri, Dec 08, 2000 at 01:40:01PM +0100, Olaf Kirch wrote:
> > This one has a minor wart. tcpdump 3.4 used to have
> > a global "extracted_ethertype" variable which is now
> > static. When parsing the 802.5 header, I have to call
> > print_llc, and need to know whether it recognized
> > the ethertype, so that I can do a raw print if it
> > didn't. This variable has now become static.
>
> Hmm. That also breaks FDDI, I suspect, as it does the same thing.
>
> I'll look at that.
I've checked in a fix; as per your comment, instead of making
"extracted_ethertype" global, I made "ether_encap_print()" and
"llc_print()" take an argument pointing to an extracted-Ethertype
variable, made "llc_print()" pass that argument on to
"ether_encap_print()", made "ether_encap_print()" set what it points to
rather than a static or global "extracted_ethertype" variable, and made
the dissectors that call "llc_print()" or "ether_encap_print()" pass a
pointer to a local "extracted_ethertype" variable to them (I wasn't sure
whether making it static to "print-ether.c" was intended to fix a
problem or not).
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:[EMAIL PROTECTED]?body=unsubscribe
