On Sun, Dec 17, 2000 at 08:45:49PM -0800, Guy Harris wrote:
> The patch in question doesn't guarantee that - it keeps more than 256
> bytes of IP address string from being put into the buffer, but the stuff
> after it could overflow the buffer.
That's why I made the buffer 1024 bytes: space for two names of 256
each plus a safetey margin. But of course using snprintf is always
preferred (there are people though who dislike it on the grounds of
not being portable, so I didn't suggest it).
> ring (it doesn't handle source-routed packets, but doing so could
> considerably complicate the BPF code generator - it'd have to handle
Yep, that was my problem as well. Linux boxes seem to generate two
byte of routing header, so I adjusted the next header offset to match
that.
> The patch adds a new DLT_IEEE802_5 DLT_ type, but I think some other
> Linux patches used DLT_IEEE802, and that's what FreeBSD and NetBSD used
> (it doesn't make sense to have a link-layer type for generic "IEEE 802",
> as the MAC header differs between the various 802.x types), so the
> current CVS tree just uses DLT_IEEE802 for token ring.
The current CVS head has that right. The tcpdump 3.5 code would call
ether_if_print when given a DLT_IEEE802 tagged packet, which works
for 802.2 but not 802.5. Which is why I added a new DLT.
> We handle both ARPHRD_IEEE802_TR and ARPHRD_IEEE802 as meaning "token
> ring" in pcap-linux.c - 2.2[.x] kernels used ARPHRD_IEEE802.
2.4.x kernels use ARPHRD_IEEE802 for a fibre channel device
(drivers/net/fc/iph5526.c) where it denotes 802.2 AFAICT.
> In some mail to tcpdump-workers, Andi Kleen said, when I asked whether
> there was any way to determine what the ISDN encapsulation was:
>
> I don't know of any (except for maybe relying on the unstable
> /dev/isdnctrl ioctls)
Well, this patch worked reliably on 2.2.x kernels for me. I'll have
to get ISDN working on 2.4 yet, so I can't tell you about that. I'll
get back to you on this issue once I've tested it.
> variety of Linux kernels and versions of the ISDN4Linux code?
I'm basically interested in i4l on stable Linux kernels. If tcpdumping
i4l on a development kernel doesn't work I couldn't care less :)
Cheers,
Olaf
PS: Try downloading the daily/tcpdump.tar.gz tarballs from your web
site -- I'm getting 403 Forbidden...
--
Olaf Kirch | --- o --- Nous sommes du soleil we love when we play
[EMAIL PROTECTED] | / | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax
[EMAIL PROTECTED] +-------------------- Why Not?! -----------------------
UNIX, n.: Spanish manufacturer of fire extinguishers.
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:[EMAIL PROTECTED]?body=unsubscribe
