(CC'ing Matt F who lead the "Make code review not suck" session at WikiDev16, not sure if his on the list or not.)
Related to the other code-review for WMF teams discussion I'd like to pass along some feedback from Evan Priestley (the Phabricator lead dev) on how we currently do code-review in Gerrit. Specifically the issue of amending other people's patches. Backgroun: * This started as this task in our Phab: https://phabricator.wikimedia.org/T121751 "Document best practices to amend a change written by another contributor" * Lot's of discussion there about what is "right" in the general sense. * Mukunda found out a way of making everyone happy (maybe) * Mukunda proposed that solution upstream, then Evan P wrote a long opinion piece on code review social contracts and basically concluded that our social contracts are toxic (a theme we keep hearing...) ** here: https://secure.phabricator.com/T10584 I won't copy/paste it all as it's long and I don't want to lose formatting, but I think it's worth while for those of us on this list to read and think about. Greg -- | Greg Grossmeier GPG: B2FA 27B1 F7EB D327 6B8E | | identi.ca: @greg A18D 1138 8E47 FAC8 1C7D | _______________________________________________ teampractices mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/teampractices
