On Sat, Dec 15, 2018 at 2:26 PM matthew green <m...@eterna.com.au> wrote: > > > I believe the right thing to do would be to just fix the type in > > uvmexp.npages to the correct type instead of adjusting the test > > to accommodate it. What would be the consequences of this? > > > > Also, I hadn't realised that the tests aren't wired into the > > build. They really should be. > > please don't change any of the structures randomly -- see my > previous email for the major issue needing to be resolved, > which will end up making this better. (if you look closely, > you'll see that the external interface is already 64 bit, > it's only the internal code that is problematic. oh well, > it would be the much less hard to fix part ... :-) >
This is good insight, thank you mrg for that. And I agree with the not changing structures randomly. (Especially by someone like me who is just getting to see how things work.) > ie, i support the change as proposed, ugly as it may be. > Yes the fix is a bit ugly. But the tests can be adapted as the interface evolves. I do not mind holding the responsibility of keeping the tests updated as the interface evolves. > > .mrg. -- Santhosh
