3. there will be a concern if we count the number of signals each time, but this sigcnts logic may can be merged with siggetinfo. 2. I can add kassert around ret. 1. I know sp cannot be NULL, and if it is NULL, the sigcnt is zero, what do you mean of code would die (which piece of code)?
2016-07-27 3:10 GMT-07:00 Christos Zoulas <chris...@zoulas.com>: > On Jul 26, 8:15pm, charles.cui1...@gmail.com (Charles Cui) wrote: > -- Subject: Re: updates? > > | Hi Christos, > | This patch fixed the bug you found > | > https://github.com/ycui1984/posixtestsuite/blob/master/patches/REALTIME_SIGNAL/0006-bug-fix-for-real-time-signals.patch > | > > Ok, I think that: > > 1. sp can't be NULL; if it was the code would die. > 2. ret can't be 0 so we should KASSERT? > 3. Is there a worry about efficiency? > > christos >
