On Fri, Feb 5, 2010 at 6:14 PM, Ted Unangst <[email protected]> wrote: > You are correct, but the patch isn't complete. You should be calling > fclose on the FILE *. Also, the table_write function has similar > bugs. I spent some time consolidating the error handling, but > eventually just gave up. (are these functions even used?)
httpd compiles for me with table_read() and table_write() deleted from ssl_util_table.c There are probably other functions in that file that can be deleted...but it should first be checked whether if anyone is interested in merging useful bits from the lastest apache 1.3.x release and whether that would add references to them. For now, concerns about memory or fd leaks from those functions can be filed to /dev/null. Philip
