On Sat, Feb 6, 2010 at 4:38 AM, Stuart Henderson <[email protected]> wrote: > On 2010/02/05 20:30, Philip Guenther wrote: >> On Fri, Feb 5, 2010 at 6:14 PM, Ted Unangst <[email protected]> wrote: >> > You are correct, but the patch isn't complete. You should be calling >> > fclose on the FILE *. Also, the table_write function has similar >> > bugs. I spent some time consolidating the error handling, but >> > eventually just gave up. (are these functions even used?) >> >> httpd compiles for me with table_read() and table_write() deleted from >> ssl_util_table.c There are probably other functions in that file that >> can be deleted...but it should first be checked whether if anyone is >> interested in merging useful bits from the lastest apache 1.3.x >> release and whether that would add references to them. > > I'm wondering about how we stand with licensing for merges, > the newer 1.3 releases are under the Apache 2 license..
Gah, between that and Henning's observation that those functions may be used by modules, I withdraw the suggestion that they be removed and instead think that the patch Ted had sent around earlier this month, with a couple corrections I had sent off-list should go in. Ted, can you send that around again? Philip Guenther
