pmsinput could have a newline after the return type like the rest,
otherwise looks good for me.
On Sat, Oct 16, 2010 at 06:36:41PM +0600, Alexandr Shadchin wrote:
> On Sat, Oct 16, 2010 at 07:26:19AM -0400, Kenneth R Westerback wrote:
> >
> > Committed! Next? :-)
> >
> > .... Ken
>
> ansify function definitions, no functional change.
>
> --
> Alexandr Shadchin
>
> Index: pms.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pckbc/pms.c,v
> retrieving revision 1.9
> diff -u -p -r1.9 pms.c
> --- pms.c 16 Oct 2010 11:24:04 -0000 1.9
> +++ pms.c 16 Oct 2010 12:30:19 -0000
> @@ -119,10 +119,7 @@ pms_setintellimode(struct pms_softc *sc)
> }
>
> int
> -pmsprobe(parent, match, aux)
> - struct device *parent;
> - void *match;
> - void *aux;
> +pmsprobe(struct device *parent, void *match, void *aux;)
> {
> struct pckbc_attach_args *pa = aux;
> u_char cmd[1], resp[2];
> @@ -160,9 +157,7 @@ pmsprobe(parent, match, aux)
> }
>
> void
> -pmsattach(parent, self, aux)
> - struct device *parent, *self;
> - void *aux;
> +pmsattach(struct device *parent, struct device *self, void *aux)
> {
> struct pms_softc *sc = (void *)self;
> struct pckbc_attach_args *pa = aux;
> @@ -282,8 +277,7 @@ pms_change_state(struct pms_softc *sc, i
> }
>
> int
> -pms_enable(v)
> - void *v;
> +pms_enable(void *v)
> {
> struct pms_softc *sc = v;
>
> @@ -291,8 +285,7 @@ pms_enable(v)
> }
>
> void
> -pms_disable(v)
> - void *v;
> +pms_disable(void *v)
> {
> struct pms_softc *sc = v;
>
> @@ -300,12 +293,7 @@ pms_disable(v)
> }
>
> int
> -pms_ioctl(v, cmd, data, flag, p)
> - void *v;
> - u_long cmd;
> - caddr_t data;
> - int flag;
> - struct proc *p;
> +pms_ioctl(void *v, u_long cmd, caddr_t data, int flag, struct proc *p)
> {
> struct pms_softc *sc = v;
> u_char kbcmd[2];
> @@ -344,9 +332,7 @@ pms_ioctl(v, cmd, data, flag, p)
> #define PS2RBUTMASK 0x02
> #define PS2MBUTMASK 0x04
>
> -void pmsinput(vsc, data)
> -void *vsc;
> -int data;
> +void pmsinput(void *vsc, int data)
> {
> struct pms_softc *sc = vsc;
> signed char dz = 0;
