I can only confirm that this doesn't break anything on my machine. The USB keyboard is still working properly.
# dmesg | grep -i ehci ehci0 at pci0 dev 29 function 7 "Intel 82801GB USB" rev 0x01: apic 1 int 23 usb0 at ehci0: USB revision 2.0 uhub0 at usb0 "Intel EHCI root hub" rev 2.00/1.00 addr 1 ehci0 at pci0 dev 29 function 7 "Intel 82801GB USB" rev 0x01: apic 1 int 23 usb0 at ehci0: USB revision 2.0 uhub0 at usb0 "Intel EHCI root hub" rev 2.00/1.00 addr 1 # dmesg | grep -i keykoard uhidev0 at uhub4 port 1 configuration 1 interface 0 "USB USB Keykoard" rev 1.10/1.10 addr 2 uhidev1 at uhub4 port 1 configuration 1 interface 1 "USB USB Keykoard" rev 1.10/1.10 addr 2 uhidev0 at uhub4 port 1 configuration 1 interface 0 "USB USB Keykoard" rev 1.10/1.10 addr 2 uhidev1 at uhub4 port 1 configuration 1 interface 1 "USB USB Keykoard" rev 1.10/1.10 addr 2 On Mon, Sep 19, 2011 at 12:27 AM, Michael Knudsen <m...@molioner.dk> wrote: > Does this make sense? > > -m. > > Index: ehci.c > =================================================================== > RCS file: /var/ocvs/src/sys/dev/usb/ehci.c,v > retrieving revision 1.118 > diff -u -p -r1.118 ehci.c > --- ehci.c 10 Jul 2011 17:34:53 -0000 1.118 > +++ ehci.c 18 Sep 2011 20:11:10 -0000 > @@ -2478,10 +2478,10 @@ ehci_alloc_sqtd(ehci_softc_t *sc) > s = splusb(); > sqtd = sc->sc_freeqtds; > sc->sc_freeqtds = sqtd->nextqtd; > + splx(s); > memset(&sqtd->qtd, 0, sizeof(ehci_qtd_t)); > sqtd->nextqtd = NULL; > sqtd->xfer = NULL; > - splx(s); > > return (sqtd); > } > > -- > <moid> no, it's a recursive acronym. It means "gcc can't compile" > > -- `` Real men run current !''
