On Sun, Sep 18, 2011 at 10:27:37PM +0200, Michael Knudsen wrote: > Does this make sense?
Since it's been taken off the list, the splusb is indeed no longer required. Either way is fine with me though, I doubt the zeroing will take that many cycles to really matter. > Index: ehci.c > =================================================================== > RCS file: /var/ocvs/src/sys/dev/usb/ehci.c,v > retrieving revision 1.118 > diff -u -p -r1.118 ehci.c > --- ehci.c 10 Jul 2011 17:34:53 -0000 1.118 > +++ ehci.c 18 Sep 2011 20:11:10 -0000 > @@ -2478,10 +2478,10 @@ ehci_alloc_sqtd(ehci_softc_t *sc) > s = splusb(); > sqtd = sc->sc_freeqtds; > sc->sc_freeqtds = sqtd->nextqtd; > + splx(s); > memset(&sqtd->qtd, 0, sizeof(ehci_qtd_t)); > sqtd->nextqtd = NULL; > sqtd->xfer = NULL; > - splx(s); > > return (sqtd); > } ok ariane@ -- Ariane
