On Sun, Oct 28, 2012 at 06:45:59PM +1100, Jonathan Gray wrote:
> On Sat, Oct 27, 2012 at 03:14:07PM +0200, Alexandre Ratchov wrote:
> > Hi,
> >
> > This diff is to use dedicated messages for flow control instead of
> > abusing clock tick messages and to enable flow control for MIDI.
> > There should be no change in behaviour, but this change is
> > necessary for future developpement of sndiod.
> >
> > any regression? ok?
>
> This seems to break seeking in mplayer (both audio and video files),
> after using the right arrow key to skip ahead it just stops.
>
thanks! ... stupid mistake. I hope the diff in my other mail works
better ;)
On Sat, Oct 27, 2012 at 03:14:07PM +0200, Alexandre Ratchov wrote:
>
> @@ -551,14 +549,15 @@ sock_attach(struct sock *f, int force)
> * get the current position, the origin is when
> * the first sample is played/recorded
> */
> - f->startpos = dev_getpos(f->dev) * (int)f->round / (int)f->dev->round;
> - f->startpending = 1;
> + f->delta = dev_getpos(f->dev) *
> + (int)f->round / (int)f->dev->round;
> + f->fillpending = f->delta;
^^^^^^^^^^^^^^^^^^^^^^^^^^
this should be zero
> f->pstate = SOCK_RUN;
> #ifdef DEBUG
> if (debug_level >= 3) {
> sock_dbg(f);
> dbg_puts(": attaching at ");
> - dbg_puti(f->startpos);
> + dbg_puti(f->delta);
> dbg_puts("\n");
> }
> #endif
