On Sun, Apr 21, 2013 at 02:28:09AM -0400, Ted Unangst wrote: > For whatever reason, I found myself looking at the m4 code. In eval.c, > there are some funny functions. I figure if you have to cast every > instance of a variable to a different type, maybe the problem is > you're starting with the wrong type. Switching to unsigned char * > inputs makes these functions much simpler. > > Also simplify and eliminate statics. I can't see any reason frombis > needs to be static, and in the case of mapvec being static just means > more work to undo writes to it.
> (I changed seen to int to make clear it's not used for character data.) On that specific note, I would change it to bool then. Yeah, it means #include <stdbool.h>, but this is mostly my code, and it makes the intent perfectly clear. It *still* requires actual tests. Drive by-coding doesn't really work here, the (unsigned char) thingies are annoying enough that they require tests. Did you try to get actual tests arranged ? cleaning this up is fairly low-pri for me... there are other issues concerning our m4, such as making it work with recent bison/recent libtool that concern me waaay more.
