On Mon, May 13, 2013 at 06:02:22AM -0500, Vladimir Támara Patiño wrote:
> 
> On Mon, May 13, 2013 at 09:16:39AM +0100, Stuart Henderson wrote:
> >Please send unified diffs, the default diff format is very hard to read
> >
> >echo diff -uNp >> ~/.cvsrc
> >
> 
> Sorry and thank you, attached is unified

> Index: Makefile
> ===================================================================
> RCS file: /cvs/src/share/locale/ctype/Makefile,v
> retrieving revision 1.6
> diff -u -p -r1.6 Makefile
> --- Makefile  16 Jul 2011 21:33:30 -0000      1.6
> +++ Makefile  13 May 2013 11:00:16 -0000
> @@ -80,14 +80,15 @@ LOCALES += en_US.ISO8859-15

> +LOCALES_ES = es_AR es_BO es_CH es_CO es_CR es_CU es_DO es_EC es_ES es_GQ 
> es_GT es_HN es_MX es_NI es_PA es_PE es_PR es_PY es_SV es_US es_UY es_VE

This mailing list thread is about adding more locales for spanish
speaking countries. The proposed symlink changes should go to a
different thread than this one.

Adding these locales is an unrelated change to making more use of
symlinks in /usr/share/locale. Please don't mix unrelated changes
together -- start a new diff and mailing list thread instead.

Not doing so complicates review and discussion of the changes, and means
that committers might need to tweak your diffs before commit. Which makes
your diffs less likely to be committed because it is more work on behalf
of the committer. And having tweaked your diffs a committer cannot just
say "patch by: you".

Reply via email to