Kyle R W Milz <kyle <at> getaddrinfo.net> writes: > > tech <at> , > > Here is an initial implementation of a generic acpi wmi framework and a > single consumer for the framework that lets the volume adjustment keys > on an asus ux31e work. > > The generic framework could be used to support hotkeys found in > different acer, dell, hp, msi, other laptops. > > This is by no means complete as wmi can do all sorts of other stupid > things like blink leds, toggle radios, control backlights, etc. The code > has some style(9) issues. > > Looking for feedback before I go any further. > > Index: arch/amd64/conf/GENERIC > =================================================================== > RCS file: /cvs/src/sys/arch/amd64/conf/GENERIC,v > retrieving revision 1.352 > diff -u -p -r1.352 GENERIC > --- arch/amd64/conf/GENERIC 4 Nov 2013 14:07:15 -0000 1.352 > +++ arch/amd64/conf/GENERIC 17 Nov 2013 05:53:40 -0000 > <at> <at> -58,6 +58,8 <at> <at> acpitoshiba* at acpi? > acpivideo* at acpi? > acpivout* at acpivideo? > acpipwrres* at acpi? > +acpiwmi* at acpi? > +acpiwmi_asus* at acpiwmi?
afaik, using underscore in device name is against OpenBSD conventions. also, if WMI maybe used to implement different vendors' features, would it be useful to use acpiwmi* at acpi? wmiasus* at acpiwmi? model to have common WMI abstraction under acpiwmi and vendor-specific stuff under wmivendor (like acpi(4) and acpiasus(4) for instance)?
