On Mon, Dec 30, 2013 at 12:45:47PM +0100, Mike Belopuhov wrote: > On Sun, Dec 29, 2013 at 22:45 -0800, Loganaden Velvindron wrote: > > Hi All, > > > > From NetBSD: > > > > Plug memory leak. Coverity CID 1596 > > > > memory leak? can you please elaborate where else this memory > is "leaking" if not back to the system.
After a short discussion on IRC, and some digging, it makes sense that the system cleanups up automatically, and therefore it is not necessary. > > > Index: src/usr.bin/column/column.c > > =================================================================== > > RCS file: /cvs/src/usr.bin/column/column.c,v > > retrieving revision 1.16 > > diff -u -p -r1.16 column.c > > --- src/usr.bin/column/column.c 26 Nov 2013 13:18:55 -0000 1.16 > > +++ src/usr.bin/column/column.c 30 Dec 2013 06:38:02 -0000 > > @@ -241,6 +241,9 @@ maketbl(void) > > (void)printf("%s\n", t->list[coloff]); > > } > > } > > + free(tbl); > > + free(cols); > > + free(lens); > > } > > > > #define DEFNUM 1000 > >