On Mon, Dec 30, 2013 at 22:50, Loganaden Velvindron wrote: > Hi Patrick, the base source code is pretty huge, and I'm sure that there are > memory/fd leak issues lurking around that need to be fixed. I'd much rather > spend time finding and fixing them :-) > > After I got feedback on my diffs, I looked at another base program > (user(8)) and > asked jj@ to have a look at the diff I just sent.
The resource handling in user is a mess, I'll give you that. It also does some unnecessary freeing, such as immediately before calling errx(). I think I would prefer to see a more comprehensive diff, though, rather than trying to cherry pick changes from netbsd. Read through the source, find the bugs, and think about corrections. Improve the code instead of just tweaking it. (There are plenty of times when small tweaks are better. So far, though, I think we should consider these small bugs as an opportunity for a more comprehensive review of each program.)
