On Thu, Jun 26, 2014 at 08:33, sven falempin wrote: > For a review i dislike > + unsigned char stdinbuf[BUFSIZE]; > and the memmove on it: > > Dear tech savvy, isn it better to malloc a buffer like this instead of > alloca it ? > or just a static buffer would be better so it is in the program mem space ?
No, there's nothing wrong with a stack buffer of moderate size in a program like this. We don't use alloca() much though.
