On Thu, Apr 23, 2015 at 04:55:17PM +1000, Jonathan Gray wrote:
> On Thu, Apr 23, 2015 at 08:42:24AM +0200, Alex Greif wrote:
> > Hi,
> >
> > It seems to be fixed upstream
> > (http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/omx/vid_dec_h264.c)
> >
> > find /usr/xenocara -name '*.c' -exec grep -rE '^[^a-zA-Z0-9]*if \([^)]*\);$'
> > {} \;
> >
> > Alex.
>
> Thanks for looking for these problems. We don't currently build the
> OpenMAX state tracker in Mesa though so I'd be inclined to not add
> another local diff and pick up the fix in a future Mesa update.
I agree.
>
> >
> >
> > Index: vid_dec_h264.c
> > ===================================================================
> > RCS file:
> > /cvs/xenocara/dist/Mesa/src/gallium/state_trackers/omx/vid_dec_h264.c,v
> > retrieving revision 1.1.1.3
> > diff -u -p -r1.1.1.3 vid_dec_h264.c
> > --- vid_dec_h264.c 20 Feb 2015 22:46:31 -0000 1.1.1.3
> > +++ vid_dec_h264.c 23 Apr 2015 06:24:59 -0000
> > @@ -681,7 +681,7 @@ static void slice_header(vid_dec_Private
> > if (priv->picture.h264.field_pic_flag) {
> > unsigned bottom_field_flag = vl_rbsp_u(rbsp, 1);
> >
> > - if (bottom_field_flag != priv->picture.h264.bottom_field_flag);
> > + if (bottom_field_flag != priv->picture.h264.bottom_field_flag)
> > vid_dec_h264_EndFrame(priv);
> >
> > priv->picture.h264.bottom_field_flag = bottom_field_flag;
> >
>
--
Matthieu Herrb
