On 6 May 2015 at 13:05, Martin Pieuchot <[email protected]> wrote: > On 20/04/15(Mon) 18:37, Mike Belopuhov wrote: >> On Tue, Apr 14, 2015 at 22:08 +0300, Lauri Tirkkonen wrote: >> > On Tue, Apr 14 2015 20:40:58 +0200, Mike Belopuhov wrote: >> > > According to 3.2 in RFC 7323: >> > > >> > > Once TSopt has been successfully negotiated, that is both <SYN> and >> > > <SYN,ACK> contain TSopt, the TSopt MUST be sent in every non-<RST> >> > > segment for the duration of the connection, and SHOULD be sent in an >> > > <RST> segment (see Section 5.2 for details). The TCP SHOULD remember >> > > this state by setting a flag, referred to as Snd.TS.OK, to one. If a >> > > non-<RST> segment is received without a TSopt, a TCP SHOULD silently >> > > drop the segment. A TCP MUST NOT abort a TCP connection because any >> > > segment lacks an expected TSopt. >> > >> > Thank you, I somehow missed the existence of this RFC. >> > >> >> Does anyone else want to comment on this? > > Diff looks good to me. Since you mentioned other *BSD in your previous > post, I look at what Linux and Solaris do and they both seem to set > timestamps on keep alive packets.
Thanks. > As for MD5 signatures Linux also include it. > Can't fix every problem with one patch... > ok mpi@ > Committed! Thanks for the review!
