There is no way this diff is going in. When softdep is 100% reliable, then we can talk.
Enabling it prematurely is ridiculous. Considering the defects are clearly described as lockups, disk space corruption -- with such a suggestion I must ask --who's side are you on?? > There was a great discussion about softdep recently: > > https://marc.info/?t=142164016900001&r=1&w=2 > > It needs extra memory, so the FAQ warns against its use on really old > architectures. > > tedu@ described the two main deterrents: > > https://marc.info/?l=openbsd-misc&m=142294185000751&w=2 > > Might it be worth making default for AMD64? The performance gain is big > in many cases. > > > > Index: editor.c > =================================================================== > RCS file: /cvs/src/sbin/disklabel/editor.c,v > retrieving revision 1.295 > diff -u -p -r1.295 editor.c > --- editor.c 8 May 2015 12:15:50 -0000 1.295 > +++ editor.c 24 Jul 2015 00:16:08 -0000 > @@ -51,6 +51,12 @@ > #define NUMBOOT 0 > #endif > > +#if defined(__amd64__) > +#define MNT_OPTS "rw,softdep" > +#else > +#define MNT_OPTS "rw" > +#endif > + > /* structure to describe a portion of a disk */ > struct diskchunk { > u_int64_t start; > @@ -1892,9 +1898,10 @@ mpsave(struct disklabel *lp) > if (fstype == FS_SWAP) { > fprintf(fp, "%s%c none swap sw\n", bdev, 'a'+j); > } else if (mi[i].mountpoint) { > - fprintf(fp, "%s%c %s %s rw 1 %d\n", bdev, > + fprintf(fp, "%s%c %s %s %s 1 %d\n", bdev, > 'a' + j, mi[i].mountpoint, > - fstypesnames[fstype], j == 0 ? 1 : 2); > + fstypesnames[fstype], MNT_OPTS, > + j == 0 ? 1 : 2); > } > } > fclose(fp); > x1
