On Sun, Sep 27, 2015 at 03:48:10PM -0400, Michael Reed wrote: > Hi all, > > Instead of using a mix of single and double quotes > to denote command invocations and literal strings, > use Ql instead. This was inspired by revision 1.425 > of bsd.port.mk [1]. > > While doing the above, I also removed a seemingly bogus > use of `Ev' prepending `-pipe'. > > Regards, > Michael > > [1]: > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share/man/man5/bsd.port.mk.5?sortby=date > >
while i don;t entirely object to this diff, i won;t be committing it either. we have no real hard or fast rules about having to use macros for quoting - i personally don;t see any benefit. jmc > > Index: mk.conf.5 > =================================================================== > RCS file: /cvs/src/share/man/man5/mk.conf.5,v > retrieving revision 1.28 > diff -u -p -r1.28 mk.conf.5 > --- mk.conf.5 30 Jul 2015 08:03:50 -0000 1.28 > +++ mk.conf.5 27 Sep 2015 19:34:24 -0000 > @@ -75,10 +75,14 @@ Binary mode. > Binary owner. > .Bq root > .It Ev BSDOBJDIR > -The real path to the system 'obj' tree, so that 'make obj' will work > correctly. > +The real path to the system object tree, so that > +.Ql make obj > +will work correctly. > .Bq Pa /usr/obj > .It Ev BSDSRCDIR > -The real path to the system sources, so that 'make obj' will work correctly. > +The real path to the system sources, so that > +.Ql make obj > +will work correctly. > .Bq Pa /usr/src > .It Ev DIRMODE > Mode for new directories. > @@ -160,7 +164,7 @@ National Language Support files owner. > Mode for non-executable files. > .Bq 444 > .It Ev XOBJDIR > -The real path to the 'obj' tree for building the X Window System. > +The real path to the object tree for building the X Window System. > .Bq Pa /usr/xobj > .It Ev XSRCDIR > The real path to the X Window System sources. > @@ -203,7 +207,7 @@ Do not build PIE objects or executables. > Do not build profiled versions of system libraries. > .It Ev PIPE > If set to > -.Qq Ev -pipe , > +.Ql -pipe , > .Xr gcc 1 > will be given the > .Fl pipe > @@ -218,20 +222,29 @@ Compile in support for S/key authenticat > A space separated list of directories, > relative to > .Ev BSDSRCDIR , > -to be skipped during "make build". > +to be skipped during > +.Ql make build . > .It Ev SUDO > Command run by > .Xr make 1 > when doing certain operations requiring root privileges > -(e.g. the "make install" portion of "make build"). > +(e.g. the > +.Ql make install > +portion of > +.Ql make build ) . > If set to > .Ev /usr/bin/doas , > -this allows one to run "make build" as a user other than root > +this allows one to run > +.Ql make build > +as a user other than root > (assuming doas is set up for that user). > .It Ev SYS_INCLUDE > Copy or symlink kernel include files into > .Pa /usr/include . > -Possible values are "symlinks" or "copies" > +Possible values are > +.Ql symlinks > +or > +.Ql copies > (which is the same as the variable being unset). > .It Ev WARNINGS > Adds appropriate warning flags (defined in >
