On Thu, Oct 01, 2015 at 11:43:15PM -0400, Michael Reed wrote: > On 10/01/15 16:38, Jason McIntyre wrote: > > On Sun, Sep 27, 2015 at 03:48:10PM -0400, Michael Reed wrote: > >> Hi all, > >> > >> Instead of using a mix of single and double quotes > >> to denote command invocations and literal strings, > >> use Ql instead. This was inspired by revision 1.425 > >> of bsd.port.mk [1]. > >> > >> While doing the above, I also removed a seemingly bogus > >> use of `Ev' prepending `-pipe'. > >> > >> Regards, > >> Michael > >> > >> [1]: > >> http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share/man/man5/bsd.port.mk.5?sortby=date > >> > >> > > > > while i don;t entirely object to this diff, i won;t be committing it > > either. we have no real hard or fast rules about having to use macros > > for quoting - i personally don;t see any benefit. > > That's fine, but could you take a look at the bogus Ev at least? > Here's a standalone diff of it: >
yep, fixed that. thanks. jmc > Index: mk.conf.5 > =================================================================== > RCS file: /cvs/src/share/man/man5/mk.conf.5,v > retrieving revision 1.28 > diff -u -p -r1.28 mk.conf.5 > --- mk.conf.5 30 Jul 2015 08:03:50 -0000 1.28 > +++ mk.conf.5 2 Oct 2015 03:41:10 -0000 > @@ -203,7 +203,7 @@ Do not build PIE objects or executables. > Do not build profiled versions of system libraries. > .It Ev PIPE > If set to > -.Qq Ev -pipe , > +.Qq -pipe , > .Xr gcc 1 > will be given the > .Fl pipe >
